Feature/hehe page #272
Merged
Feature/hehe page #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
pontussjostedt
approved these changes
May 5, 2024
afroborg
requested changes
May 5, 2024
afroborg
reviewed
May 5, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Coverage report
Test suite run success248 tests passing in 20 suites. Report generated by 🧪jest coverage report action from 6417caa |
|
The GitHub Action should be run again after the pdf-to-png PR has been merged, and after vault has been unlocked. A Edit: Closes #241 |
|
I have removed this deploy now 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Adds extra Hehe functionality to ekorre that converts the cover page of a Hehe PDF into a PNG and saves it in the database. Also adds a new integration test to test this functionality
Adds a unit test to check a file other than a PDF is not accepted for a Hehe
Exposes the Hehe
uploadedAtproperty as aDateTimeso this can be used in the frontendAbstracts out functionality for uploading files in jest tests, and removing uploaded files, in both file- and Hehe tests
Note: This PR should be merged at the same time as a efterphest Hehe PR